feat: add reverse proxy step to onboarding for feature flags #20906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +52 B (0%) Total Size: 821 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
xrdt
reviewed
Mar 13, 2024
…to onboarding-proxy-step
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
zlwaterfield
force-pushed
the
onboarding-proxy-step
branch
from
810b0ea to
e724cd5
Compare
|
Here is the A/B test: https://us.posthog.com/project/2/experiments/24377. |
raquelmsmith
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A reverse proxy allows users to send events to PostHog Cloud using your own domain. This means that events are sent from their own domain and are less likely to be intercepted by tracking blockers.
Product like feature flags require a proxy in order to make sure the necessary requests succeed for all users.
Changes
We already have the documentation for how to set up a proxy. This PR is adding the a step to the onboarding flow to let the user know they should set one up.
Few notes:
Other items discussed while doing this: